feat(i18n): add Vietnamese translations for docs and WebUI#451
feat(i18n): add Vietnamese translations for docs and WebUI#451thanhnn91qn-afk wants to merge 1 commit intoCJackHwang:mainfrom
Conversation
- Add full Vietnamese README (README.vi.md) and link from README.MD / README.en.md - Add docs/README.vi.md and docs/DEPLOY.vi.md (concise local-first deployment guide) - Translate config.example.json and .env.example comments to Vietnamese - Add WebUI vi.json locale (489 keys, 1:1 with zh.json) and "vietnamese" label in en/zh - Set Vietnamese as default language in webui/src/i18n.jsx with safe en fallback - Update LanguageToggle.jsx to cycle VI -> EN -> ZH - Extend .gitignore to ignore *.exe, .env.*.production, run.bat and nested clones Co-authored-by: Cursor <cursoragent@cursor.com>
|
@thanhnn91qn-afk is attempting to deploy a commit to the cjack's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for your effort on the Vietnamese translation. However, I have decided to close this PR for the following reasons: |
|
Thank you for your detailed feedback and for clearly explaining the issues
with my PR.
After reviewing your comments, I fully understand and agree with the
project’s principles and development direction, especially regarding
language priority, configuration structure, and default UI logic. I realize
that my changes unintentionally affected the original design and standards
of the repository.
Therefore, please feel free to proceed with closing this PR. I respect your
decision.
For future contributions, I will make sure to strictly follow the stated
guidelines — only adding files such as "README.vi.md", documentation under
the "docs/" folder, and the "vi.json" file in "locales", without modifying
the fallback logic, default language settings, or existing UI structure.
Thank you for your time in reviewing and guiding me. I hope to contribute
more appropriately in future submissions.
Vào 20:34, CN, 10 thg 5, 2026 CJACK. ***@***.***> đã viết:
… Closed #451 <#451>.
—
Reply to this email directly, view it on GitHub
<#451 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3DP25IGWJOMQ35ILMD72LT42CAOVAVCNFSM6AAAAACYVO5TX2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRVGM2TGOBUGE4DGMY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2 participants
Summary / Tóm tắt
Add Vietnamese (
vi) language support across user-facing surfaces so DS2API is friendlier to Vietnamese developers.Bổ sung hỗ trợ tiếng Việt (
vi) cho các bề mặt hướng người dùng để DS2API thân thiện hơn với lập trình viên Việt Nam.What's new / Có gì mới
README.vi.md– full Vietnamese mirror ofREADME.MDdocs/README.vi.md– Vietnamese docs indexdocs/DEPLOY.vi.md– concise local-first deployment guide in VietnameseREADME.MD,README.en.md,docs/README.md,docs/DEPLOY.md,docs/DEPLOY.en.mdso users can switch languagesconfig.example.jsonand.env.exampleto Vietnamese (no key/value structure changes)webui/src/locales/vi.json– 1:1 withzh.json(489 keys)webui/src/i18n.jsxnow exposesviand falls back safely (vi → en→ original key)LanguageToggle.jsxcyclesVI → EN → ZHlanguage.vietnameselabel to existingen.jsonandzh.json.gitignoreextended to ignore*.exe,.env.*.production,run.batand accidental nested clones (no behavior change to authors' workflow)Notes for reviewer / Ghi chú cho người review
zhas a fallback for users who have explicitly chosen Chinese in theirlocalStorage. The default for new visitors whose browser is notvi/zh/enisvi; you can flip the constantDEFAULT_LANGinwebui/src/i18n.jsxif you'd rather keepzhas the global default.internal/,api/,cmd/) was touched – translations are limited to docs, config templates and the WebUI locale layer.npm run build --prefix webuisucceeds locally (1774 modules transformed); admin assets continue to ship fromstatic/admin/.How to test / Cách kiểm thử
Happy to adjust the default language behavior, copy or scope per maintainer preference.
Sẵn lòng điều chỉnh ngôn ngữ mặc định, văn phong hoặc phạm vi theo ý của tác giả.